Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): use barel export everywhere #57

Merged
merged 4 commits into from
Aug 4, 2020
Merged

feat(core): use barel export everywhere #57

merged 4 commits into from
Aug 4, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 3, 2020 •
edited
Loading

  • every folder should export the regular index barel not a modified version of it, for example Formatters, Filters, ... were all exporting their own set, these export were renamed as "formatters.index.ts", ...
  • this will allow to import any Editors, Filters, ... into Angular-Slickgrid

@ghiscoding-SE
feat(core): use barel export everywhere
fb008b8 
- every folder should export the regular index barel not a modified version of it, for example Formatters, Filters, ... were all exporting their own set, these export were renamed as "formatters.index.ts", ...
- this will allow to import any Editors, Filters, ... into Angular-Slickgrid
@ghiscoding-SE
Merge remote-tracking branch 'origin/master' into fix/index-exports
2dbacfe
@ghiscoding-SE
refactor(core): add more npm scripts
879ea95
@ghiscoding-SE
refactor(core): rebuild vanilla bundle zip file
f27510c
@codecov
Copy link

codecov bot commented Aug 4, 2020 •
edited
Loading

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #57    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          186       193     +7     
  Lines        10096     10209   +113     
  Branches      3314      3423   +109     
==========================================
+ Hits         10096     10209   +113
Impacted Files Coverage Δ
...on/src/filter-conditions/executeMappedCondition.ts 100.00% <ø> (ø)
...ckages/common/src/aggregators/aggregators.index.ts 100.00% <100.00%> (ø)
packages/common/src/aggregators/index.ts 100.00% <100.00%> (ø)
packages/common/src/editors/editors.index.ts 100.00% <100.00%> (ø)
packages/common/src/editors/index.ts 100.00% <100.00%> (ø)
...on/src/filter-conditions/filterConditions.index.ts 100.00% <100.00%> (ø)
packages/common/src/filter-conditions/index.ts 100.00% <100.00%> (ø)
packages/common/src/filters/filters.index.ts 100.00% <100.00%> (ø)
packages/common/src/filters/index.ts 100.00% <100.00%> (ø)
packages/common/src/formatters/formatters.index.ts 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9416c4d...f27510c. Read the comment docs.

@ghiscoding ghiscoding merged commit d068fc5 into master Aug 4, 2020
@ghiscoding ghiscoding deleted the fix/index-exports branch August 4, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @ghiscoding-SE